Update and fix SYCL headers #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5e8628.
…into update-sycl
bashbaug
reviewed
Sep 6, 2024
I don't actually remember what my environment was that only worked with these changes, but I am unable to replicate that environment now. I've gone ahead and removed the changes, my bad on that part! |
bashbaug
approved these changes
Jan 16, 2025
MichalMrozek
approved these changes
Jan 20, 2025
|
Fixes already upstreamed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that SYCL headers were outdated and were failing to build when following build instructions in the README. This PR:
Adds the necessary includes in cmake files for builds with-DBUILD_SYCL=onto compile successfullysycl::info::device::opencl_c_version, which is no longer in the SYCL spec<sycl/sycl.hpp>headers instead of obsolete<cl/sycl.hpp>I would like to raise attention to point 2 however: I am unsure if printing the
opencl_c_versionis important, but judging by the fact that the SYCL spec does not provide alternatives for this in newer specs, I am assuming this is no longer applicable. If the e.g. opencl version is still important debugging information, please let me know and I will add a print for e.g.sycl::info::device::versioninstead. Thanks for understanding!